Skip to content

CLN: Initialization coincides with mapping, hence with uniqueness check #13594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CLN: Initialization coincides with mapping, hence with uniqueness check #13594

wants to merge 1 commit into from

Conversation

toobaz
Copy link
Member

@toobaz toobaz commented Jul 9, 2016

  • tests added / passed
  • passes git diff upstream/master | flake8 --diff

Rebased version of #10229 which was actually not fixed by #10199.

Nothing particular relevant, just wanted to delete this branch locally and noticed it still applies: you'll judge what to do of it.

@sinhrks sinhrks added Clean Indexing Related to indexing on series/frames, not to indexes themselves labels Jul 9, 2016
@sinhrks sinhrks added this to the 0.19.0 milestone Jul 9, 2016
@jreback
Copy link
Contributor

jreback commented Jul 9, 2016

can you make a tests which fails w/o this and passes with.

@toobaz
Copy link
Member Author

toobaz commented Jul 9, 2016

I don't think, but feel free to suggest.

@jreback jreback closed this in 71a0675 Jul 15, 2016
@jreback
Copy link
Contributor

jreback commented Jul 15, 2016

thanks @toobaz this looks fine.

@toobaz toobaz deleted the fix_checkunique branch July 17, 2016 07:45
@jreback jreback mentioned this pull request Sep 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@toobaz @jreback @sinhrks